Feedback and Additions on Azure Functions walkthrough #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing Functions CLI as pre-requisite Remove numbered versioning of CLI - although this is helpful, it is difficult to maintain the doc Re-structure deploment setup of docs - This is to add in VS Code stuff Added documentation on how to have url be http://localhost:7071/graphql Changed Apollo Server sample code to be from our getting started
ErickWendel
approved these changes
Feb 11, 2019
|
Hi @michael-watson thanks for the feedback 😄 At my examples, I tried to maintain the same example that I saw before on the Apollo Server website. At this PR you change from our object list to a string hello world's example. I think that is good to the reader just focus on the Apollo features, so I agree with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Erick, thanks for your hard work on this. Over the weekend I walked through everything and added debugging/deployment for VS Code. I made some small tweaks to standardize things, but most of the changes were minor.
Let me know if you have any questions, happy to talk about any changes you think should be made! I should be able to get some members from the team to review once you have accepted these changes.